Hi Robert, Hum, I integrated the changes, but found the apply(Drawable& drawable) does not call apply(Node&)... Why?
Sukender ----- Mail original ----- De: "Sukender" <[email protected]> À: "OpenSceneGraph Submissions" <[email protected]> Envoyé: Mercredi 27 Août 2014 12:02:16 Objet: Re: [osg-submissions] Fix for 3DS reader Hi Robert, No problem about the delay... Take your time! And glad to see the Geode/Drawable thing is okay. Cheers, Sukender ----- Mail original ----- De: "Robert Osfield" <[email protected]> À: "OpenSceneGraph Submissions" <[email protected]> Envoyé: Lundi 25 Août 2014 15:45:45 Objet: Re: [osg-submissions] Fix for 3DS reader Hi Sukender, I am planning to do a general submissions purge once I complete a bit more of my osgUI work, so will tackle your 3ds changes then. Your two suggestions about StateSet::ParentList and NodeVisitor::apply(Geode&) to reflect the fact that Drawable is now a Node, and Geode is now a Group are sound and I've gone ahead and made the relevant changes and checked them into svn/trunk. Cheers, Robert. On 25 August 2014 13:19, Sukender < [email protected] > wrote: Hi Robert, Please find attached: " Fix for 3DS reader, which may read wrong triangles. Actually, indices may suffer a 'short int' overflow, in two places. " Thank you for merging :) Not related, but I think : 1. The osg::StateSet::ParentList should now be a vector<Node*> instead of a vector<Object*> (now that Drawables are Nodes), and 2. NodeVisitor should read: void NodeVisitor::apply(Geode& node) { apply(static_cast<Group&>(node)); } instead of; void NodeVisitor::apply(Geode& node) { apply(static_cast<Node&>(node)); } ...don't you think? Cheers, -- Sukender _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
