Hi Roman, Thanks for zipped up the changes. It could be that the forum is playing silly buggers with attachments. I use the mailing list because it's just far more reliable - "what you see is what I get "if you will.
I have done a first pass review and will hold back on any merge right now. It looks to me that the implementations are not as clean as they could be - I'm not yet familiar with all the extensions so can't immediately decide exactly how things should be implemented so will have to spend some time on background reading and have a second pass at it. When merging a collection of separate changes I also need to review, test and merge as eac set of changes as separate entitities rather than a collection of independent changes all thrown together. This is important as we need to be able to trace changes and sometimes have to revert when their is regression - what you don't want is lots of non related items fogging the investigation and management of changes. So when I get collection of unrelated changes to the OSG I have to work doubly hard to pull everything apart before I can even begin a proper review of each individual portion. Robert. On 11 March 2015 at 12:17, Roman Grigoriev <[email protected]> wrote: > Hi,Robert > It's too strange that you can't download patch, but nevermind here is > modified files > Here is some explanations > According to > https://www.opengl.org/registry/specs/ARB/glx_create_context.txt > you can create context with core GLX_CONTEXT_CORE_PROFILE_BIT_ARB and > compatability GLX_CONTEXT_COMPATIBILITY_PROFILE_BIT_ARB > so when you create context you put it to traits->glContextProfileMask > also you can create context with GLX_CONTEXT_FORWARD_COMPATIBLE_BIT_ARB or > GLX_CONTEXT_DEBUG_BIT_ARB, so you put it to traits->glContextFlags > on windows you have also same constants with WGL prefix > Roman > > ------------------ > Read this topic online here: > http://forum.openscenegraph.org/viewtopic.php?p=63034#63034 > > > > > Attachments: > http://forum.openscenegraph.org//files/p1tar_674.gz > > > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
