Hi Robert, thanks for the reaction. I don't know what method you use, or why the pull-diff is not as good - it may very well be better. The pull-requests system does however have one major advantage: It gives others credit. Anyone who makes a pull-request that is accepted is marked as an author in github, and that will give them credit, but much more, it builds credibility to the OpenSceneGraph project as such, as it tells at the first glance that it is not a 1-man-show, but a true, viable, vibrating open source community. That is quite important, so while I will send in the files manually, it would be good for OpenSceneGraph to move to a pull-request based system, and I am sure it is possible to download a pull request to view it locally in the diff-viewer of choice.
Cheers, Kristofer On Sat, Mar 12, 2016 at 7:00 PM, Robert Osfield <[email protected]> wrote: > Hi Kristofer > > I am away on a trip this week so won't be merging submissions. As general > note the official route for submitting changes is still through the > osg-submissions lists. Moving to github hasn't changed this. > > I dabbled briefly with merging a couple of pull request but found it not > as good as the way reviewing submissions that I have used over the years. > > For now I am not monitoring pull requests, I do however monitor the > osg-submissions list even if I can't merge changes right away. > > Robert > On 12 Mar 2016 3:09 am, "Kristofer Tingdahl" <[email protected]> > wrote: > >> Dear Robert, >> >> I sent in a pull request via github last month ( >> https://github.com/openscenegraph/OpenSceneGraph/pull/60?_pjax=%23js-repo-pjax-container >> ) >> >> any reactions? If it is not of your liking, or if I should have done it >> in a different way, please let me know. Any reaction is appreciated. >> >> Best regards, >> >> >> Kristofer >> >> -- >> *Dr. Kristofer Tingdahl* >> *Chief Executive Officer**______________________________* >> >> *dGB Earth Sciences* >> Phone: +31 53 4315155 >> Skype: dgbtingdahl >> E-mail: [email protected] >> Internet: dgbes.com & opendtect.org*______________________________* >> >> >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> >> > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > -- *Dr. Kristofer Tingdahl* *Chief Executive Officer**______________________________* *dGB Earth Sciences* Phone: +31 53 4315155 Skype: dgbtingdahl E-mail: [email protected] Internet: dgbes.com & opendtect.org*______________________________*
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
