Dear Robert, compiles without any shadow problems (or any other warnings) on my mac. Thanks!
- Kristofer On Thu, May 26, 2016 at 11:51 PM, Kristofer Tingdahl < [email protected]> wrote: > Robert, > > Thanks for the effort! I will rebase and let you know if my compiler > finds anything. > > Cheers, > > Kristofer > > ---------- > Dr M. Kristofer Tingdahl > CEO dGB Earth Sciences > On May 26, 2016 5:46 PM, "Robert Osfield" <[email protected]> > wrote: > >> Hi Kristofer, >> >> I was able to check out your changes to a clone of your OpenScenGraph >> repository and generated a patch set. I wasn't happy with the >> wholesale nature of how the merge was applied. I haven't yet come up >> with a more fine grained way of reviewing and merging changes, rather >> than apply the whole lot I have decide to add the -Wshadow to the gcc >> build and go through the OSG fixing the warnings as they came up. >> While far more laborious I'd rather put the work in and make decisions >> on how the code should be that accept a big set of changes in a way >> that is easy to not spot errors. >> >> These changes are now checked into OSG master. Could you rebase your >> repository to reflect the new history of the main OpenSceneGraph >> repostiory. >> >> Thanks, >> Robert. >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> > -- *Dr. Kristofer Tingdahl* *Chief Executive Officer**______________________________* *dGB Earth Sciences* Phone: +31 53 4315155 Skype: dgbtingdahl E-mail: [email protected] Internet: dgbes.com & opendtect.org*______________________________* -- OpendTect: selected recipient of SEG's <http://dgbes.com/index.php/key-words/news/winner-of-seg-s-distinguished-achievement-award> Distinguished Achievement Award 2016 <http://dgbes.com/index.php/key-words/news/winner-of-seg-s-distinguished-achievement-award>
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
