Hi Kristofer,

I was able to check out your changes to a clone of your OpenScenGraph
repository and generated a patch set.  I wasn't happy with the
wholesale nature of how the merge was applied.  I haven't yet come up
with a more fine grained way of reviewing and merging changes, rather
than apply the whole lot I have decide to add the -Wshadow to the gcc
build and go through the OSG fixing the warnings as they came up.
While far more laborious I'd rather put the work in and make decisions
on how the code should be that accept a big set of changes in a way
that is easy to not spot errors.

These changes are now checked into OSG master.  Could you rebase your
repository to reflect the new history of the main OpenSceneGraph
repostiory.

Thanks,
Robert.
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to