Hi Julien, I have just done a review and am left a bit confused by the intention of the submission. I don't know where this submission might end up but for now I don't feel it's a state that's ready to merge with git master.
Is all this functionality meant to add support for glDrawArraysIndirect? For binding of buffer objects for glDrawArraysIndirect I feel that perhaps glDrawElements support for UBO's might be a good template. Placing a new BufferObject type into include/osg/BufferObject might also be appropriate. As a first step it would be appropriate to add the function entry points to the GLExtensions class as this is now the best place to add GL extensions in the core OSG rather than having a local extensions object nested within a class like DrawArraysIndirect. Could you also post the header for DrawIndirectPrimitives, as you didn't originally include this. As a general comment, when adding support for glDrawArraysIndirect I'd be inclined to go with the class name osg::DrawArraysIndirect as this is keeping with how the rest of the OSG names GL releated classes i.e. glDrawArrays -> osg::DrawArrays etc. Cheers, Robert. On 28 May 2016 at 16:12, Julien Valentin <[email protected]> wrote: > Hi, > I updated osg::TextureBuffer in order to use delegation to a bufferobject > (osg::TextureBufferObject)instead of raw gl > Maybe this new class should be added in BufferObject files > > It require some minor change in osggpucull example but nothing drastic (just > a few indirection to the new texbuffer member) > > > > ... > > > Thank you! > > Cheers, > Julien > > ------------------ > Read this topic online here: > http://forum.openscenegraph.org/viewtopic.php?p=67268#67268 > > > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
