The main interest should be there: https://github.com/mp3butcher/OpenSceneGraph/blob/c07176191d9a3e5c4743002a3802d36c774d8a8d/src/osg/TextureBuffer.cpp Changes allows to bind any BufferObject type to TextureBuffer. I keeped the setImage method only for compliance with example (the default bufferobect created in this method would perhaps worth a TextureObjectBuffer class in order not to hack a VertexBufferObject)
My main goal with these changes is to allow transformfeedback to the BufferObject attached to the TextureBuffer... but I don't want yet to fully integrate IndirectRendering (I've just added gl func in GLExtensions for the moment) My secondary goal is to serialize TransformFeedBack patterns, for this I had to create BufferData,BufferObject and BufferIndexBinding serializers. mp3butcher wrote: > Hi Robert > I've already do a lot of stuff..I'm trying to submit piece by piece but it's > not a good idea. > Further the use of an other BufferObject subclass as all buffers are unified > seams not a right idea. > You can see all changes I've made here > https://github.com/openscenegraph/OpenSceneGraph/compare/master...mp3butcher:master > > Should I mail individually files or could I create a pullrequest? > > > robertosfield wrote: > > Hi Julien, > > > > I have just done a review and am left a bit confused by the intention > > of the submission. I don't know where this submission might end up > > but for now I don't feel it's a state that's ready to merge with git > > master. > > > > Is all this functionality meant to add support for glDrawArraysIndirect? > > > > For binding of buffer objects for glDrawArraysIndirect I feel that > > perhaps glDrawElements support for UBO's might be a good template. > > Placing a new BufferObject type into include/osg/BufferObject might > > also be appropriate. > > > > As a first step it would be appropriate to add the function entry > > points to the GLExtensions class as this is now the best place to add > > GL extensions in the core OSG rather than having a local extensions > > object nested within a class like DrawArraysIndirect. > > > > Could you also post the header for DrawIndirectPrimitives, as you > > didn't originally include this. > > > > As a general comment, when adding support for glDrawArraysIndirect I'd > > be inclined to go with the class name osg::DrawArraysIndirect as this > > is keeping with how the rest of the OSG names GL releated classes i.e. > > glDrawArrays -> osg::DrawArrays etc. > > > > Cheers, > > Robert. > > > > On 28 May 2016 at 16:12, Julien Valentin <> wrote: > > > > > Hi, > > > I updated osg::TextureBuffer in order to use delegation to a bufferobject > > > (osg::TextureBufferObject)instead of raw gl > > > Maybe this new class should be added in BufferObject files > > > > > > It require some minor change in osggpucull example but nothing drastic > > > (just a few indirection to the new texbuffer member) > > > > > > > > > > > > ... > > > > > > > > > Thank you! > > > > > > Cheers, > > > Julien > > > > > > ------------------ > > > Read this topic online here: > > > http://forum.openscenegraph.org/viewtopic.php?p=67268#67268 > > > > > > > > > > > > > > > _______________________________________________ > > > osg-submissions mailing list > > > > > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > > > > > > > _______________________________________________ > > osg-submissions mailing list > > > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > > > ------------------ > > Post generated by Mail2Forum > ------------------ Read this topic online here: http://forum.openscenegraph.org/viewtopic.php?p=67306#67306 _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
