Hi Julien, On 15 June 2016 at 19:25, Julien Valentin <[email protected]> wrote: > -Yes, I added INDIRECTDRAWBUFFERBINDING in StateAttribute Types > -I also added the setIndex Function for BufferIndexedBinding serialization > purpose ... Is there a problem with it?
The problem lies in the call to the parent StateSet's, it means that this "innocent" little change of a integer could spill over into threading issues when the parent StateSet's containers get rearranged to account for the change. This issue would could be hard to spot as outwardly the contents of the StateSet might seem to be constant as no code is directly change a particular StateSet's contents, only state within a child. This case would be rare but problems like this can and do crop up, we need to avoid them if possible. I am not willing to merge this change without thinking fully about the potential consequences and about the alternatives that mean we don't need such a change your parents workaround. Robert. _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
