Hi Laurens, Thanks, I have now merged your changes to GLExtensions and checked these into git master.
I have merged you glViewerArray etc. support as well and have tested the example, and now reviewing the code and how it might be evolved to be in keeping with how the other similar classes in the OSG have been done already such as ClorMaski etc. I will keep you up to date with how things progress. Robert. On 29 June 2016 at 08:17, Voerman, L. <[email protected]> wrote: > Hi Robert, > you are correct, I forgot to add the modifications to the GLExtentions. Now > attached. > Regards, Laurens. > > On Tue, Jun 28, 2016 at 7:26 PM, Robert Osfield <[email protected]> > wrote: >> >> Hi Laurens, >> >> I have just started doing a review of your viewport array submission >> but have hit upon some errors that suggest that you've modified >> GLExtensions but haven't included these with your submission: >> >> [ 0%] Building CXX object src/osg/CMakeFiles/osg.dir/ViewportArray.o >> /home/robert/OpenSceneGraph/src/osg/ViewportArray.cpp: In member >> function ‘virtual void osg::ViewportArray::apply(osg::State&) const’: >> /home/robert/OpenSceneGraph/src/osg/ViewportArray.cpp:36:22: error: >> ‘const class osg::GLExtensions’ has no member named >> ‘isViewportArraySupported’ >> if (!extensions->isViewportArraySupported) >> ^ >> /home/robert/OpenSceneGraph/src/osg/ViewportArray.cpp:43:25: error: >> ‘const class osg::GLExtensions’ has no member named >> ‘glViewportIndexedf’ >> extensions->glViewportIndexedf(index, >> static_cast<GLfloat>(vp->x()), static_cast<GLfloat>(vp->y()), >> static_cast<GLfloat>(vp->width()), >> static_cast<GLfloat>(vp->height())); >> ^ >> /home/robert/OpenSceneGraph/src/osg/ViewportArray.cpp:31:24: warning: >> unused variable ‘contextID’ [-Wunused-variable] >> const unsigned int contextID = state.getContextID(); >> ^ >> /home/robert/OpenSceneGraph/src/osg/ScissorArray.cpp: In member >> function ‘virtual void osg::ScissorArray::apply(osg::State&) const’: >> /home/robert/OpenSceneGraph/src/osg/ScissorArray.cpp:36:22: error: >> ‘const class osg::GLExtensions’ has no member named >> ‘isViewportArraySupported’ >> if (!extensions->isViewportArraySupported) >> ^ >> /home/robert/OpenSceneGraph/src/osg/ScissorArray.cpp:43:25: error: >> ‘const class osg::GLExtensions’ has no member named ‘glScissorIndexed’ >> extensions->glScissorIndexed(index, >> static_cast<GLfloat>(vp->x()), static_cast<GLfloat>(vp->y()), >> static_cast<GLfloat>(vp->width()), >> static_cast<GLfloat>(vp->height())); >> ^ >> /home/robert/OpenSceneGraph/src/osg/ScissorArray.cpp:31:24: warning: >> unused variable ‘contextID’ [-Wunused-variable] >> const unsigned int contextID = state.getContextID(); >> ^ >> /home/robert/OpenSceneGraph/src/osg/DepthArray.cpp: In member function >> ‘virtual void osg::DepthArray::apply(osg::State&) const’: >> /home/robert/OpenSceneGraph/src/osg/DepthArray.cpp:41:22: error: >> ‘const class osg::GLExtensions’ has no member named >> ‘isViewportArraySupported’ >> if (!extensions->isViewportArraySupported) >> ^ >> /home/robert/OpenSceneGraph/src/osg/DepthArray.cpp:57:25: error: >> ‘const class osg::GLExtensions’ has no member named >> ‘glDepthRangeIndexed’ >> extensions->glDepthRangeIndexed(index, >> static_cast<GLclampd>(depth->getZNear()), >> static_cast<GLclampd>(depth->getZFar())); >> ^ >> /home/robert/OpenSceneGraph/src/osg/DepthArray.cpp:33:24: warning: >> unused variable ‘contextID’ [-Wunused-variable] >> const unsigned int contextID = state.getContextID(); >> >> ^ >> >> Could you post these? >> Robert. >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
