Hi Alessandro,

I just had quick look at the differences between your code and the
original code, there are a great number of changes required to handle
just one aspect of different source data.  The code also has repeated
comments of //For now only allow 1 texture which is a sure indication
that the code isn't yet fully functional.

I haven't yet reviewed the StateSetContent class that is being set by
this convert function, my guess is that this is a bit too limited and
need to be improved to handle multiple textures as per the source
data, and then for the code that unpacks the various ways textures can
be sourced and assigned in a reusable ways so that there isn't these
repeated blocks with tiny differences in them.  Instead there should
be some helper methods, or perhaps functors to help improve code reuse
and avoid these mega long methods.

Once this is done it should be easier to slot in the different ways
that textures can be specified.

BTW, I'm not the original author of this code and don't have access to
a modelling tool that provides FBX files so I'm having to learn stuff
just from the source code and review whether it makes sense form a
high level.

Robert.
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to