On Tue, Mar 18, 2008 at 2:18 PM, Wojciech Lewandowski <[EMAIL PROTECTED]> wrote: > > Items like back ground colour is certainly something that can be > > useful to inherit, but... perhaps if the coder wants this then its > > fair enough to actually require them to set it. Clearly wel need to > > have a good think about inheritance of settings in viewer and scene > > graph Cameras, and SceneView which also uses CullSettings behind the > > scenes in osgViewer. > > If I understand correctly you opt for default NULL inheritance mask. Right ? > I agree that this should solve this particular issue. Don't know how this > would affect other cull settings, though.
Other effects is what we need to be careful about and why making top level changes right now is probably a bit too quick. Without looking into further my guess is that SceneView needs to inherit all CullSettings, slave Cameras should inherit their CullSettings, but scene graph Cameras might be better off not inheriting settings. Or perhaps we always inherit unless one sets a variable locally - this would require an approach like in your extra parameter suggestion. > > Right now I think the thing to do is apply the fix to osgShadow, then > > move on to a wider review of inheritance of CullSettings. > > I think I understand your motives. Do you want me to add this second line > and send a fix for osgShadow::ShadowMap ? I may try to update PSSM and SSM > as well but I won't guarantee I will be able to fully test them. It may even be worth doing a setInheritanceMask(0x0) on all these osgShadow implements. The right of the Camera usages needs look at as well. I'm just tying up some other work, once this is done I'll do a quick review of Camera usage. Robert. _______________________________________________ osg-users mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

