Hi Robert, Wojtek,

Robert Osfield wrote:

The code in RenderStage is mainly there as fallback to avoid limits
applied by the first FBO supporting drivers.  Removing this
requirement should now be possible - we can do this and then do a call
for testing.

That's what I thought. I think that would be good, since it would reduce video memory requirements when the defaults create more attachments than are really needed... Possibly a large reduction when the only attachment needed was depth component (i.e. shadow map for example).

Wojciech Lewandowski wrote:
One problem that this change might introduce is that if users make not
explicitly specified both a depth and colour buffers in their Camera
settings, but instead have relied upon this behavior of RenderStage.

I think a solution could be adding default COLOR_BUFFER and DEPTH_BUFFER attachments to FBO Cameras. They are not set currently and thus dirty work of setting them is done by RenderStage. If they were set by default in Camera users could directly override or remove them.

If they were set by default it should also work for those who relied on their presence.

Is this really needed? I know we don't want to break users' existing apps, but in general, we should assume they know what they're doing right?

The solution above would mean that someone who knows what they're doing would need to remove attachment(s) instead of adding just the ones they need (which is counter-intuitive IMHO). If nothing is set by default then the programmer has to think about what attachments they need, and using no attachments could result in a clear error message that you need to add the attachments you need to your FBO camera...

What do you think?

J-S
--
______________________________________________________
Jean-Sebastien Guay    [email protected]
                               http://www.cm-labs.com/
                        http://whitestar02.webhop.org/
_______________________________________________
osg-users mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Reply via email to