Hi Johm, Try ENDIF() rather than ENDIF.
Robert. On Fri, Jul 16, 2010 at 3:13 PM, John Kelso <[email protected]> wrote: > Good news! > > As a quick test I deleted the line > > FRAMEWORK DESTINATION /Library/Frameworks > > in CMakeModules/ModuleInstall.cmake, and everything builds and installs just > fine. > > I tried this: > > INSTALL( > TARGETS ${LIB_NAME} > RUNTIME DESTINATION ${INSTALL_BINDIR} COMPONENT libopenscenegraph > LIBRARY DESTINATION ${INSTALL_LIBDIR} COMPONENT libopenscenegraph > ARCHIVE DESTINATION ${INSTALL_ARCHIVEDIR} COMPONENT libopenscenegraph-dev > IF(APPLE) > FRAMEWORK DESTINATION /Library/Frameworks > ENDIF > ) > > but get the error: > > CMake Error: Error in cmake code at > /usr/local/HEV-beta/apps/osg/osg-2.9.8/OpenSceneGraph/CMakeModules/ModuleInstall.cmake:33: > Parse error. Function missing ending ")". Instead found left paren with > text "(". > > I suspect this is an easy fix for someone who knows cmake. > > Thanks, > > John > > On Fri, 16 Jul 2010, John Kelso wrote: > >> Hi, >> >> Yes, I'm very willing to do this, but realisticaly won't have a chance to >> do >> it until August. >> >> But, I'll take a look at the effort involved right now, and if it isn't >> too >> messy I'll see if I can fit into the interstisal spaces of my schedule and >> knock it out. >> >> Thanks, >> >> John >> >> On Fri, 16 Jul 2010, Jean-Sébastien Guay wrote: >> >>> Hi Robert, John, >>> >>>> Guarding the FRAMEWORK keyword sounds like the sensible thing to do, >>>> it's a bit of pain, but it would allow those using cmake out of the >>>> box on older OS spins to keep working. >>> >>> Yes, but who will do it? It would need to be someone who runs into the >>> problem... John, do you have a bit of time to look into it? >>> >>> In theory you'd just have to surround lines that have FRAMEWORK with >>> if(APPLE)...ELSE()...ENDIF() constructs. Hopefully you won't have to >>> copy whole blocks into the ELSE side, otherwise you could make a macro >>> you put in the CMakeModules/OSGMacroUtils.cmake that would do what you >>> need, i.e. omit FRAMEWORK on non-APPLE configs. >>> >>> Argh, messy... :-) >>> >>>> So far it hasn't been a big problem, but it's something we should >>>> monitor - just how hassle is it to support older CMake versions. On a >>>> pure engineering standpoint I'd rather we'd just have a single CMake >>>> min version as well, but from a pragmatic standpoint it can shift the >>>> a small amount of disruption in one place to more disruption >>>> elsewhere. Where to draw the line is the difficult thing, something I >>>> try to do on a case by case basis when reviewing submissions, and by >>>> monitoring the pain threshold out in the community. >>> >>> I agree with you, and I remembered that some systems and distributions >>> are stuck on old versions for a long time (as is the case for John), so >>> yeah, going around guarding the FRAMEWORK keyword is pretty much the >>> only thing we can do. >>> >>> Thanks, >>> >>> J-S > > _______________________________________________ > osg-users mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org > > _______________________________________________ osg-users mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
