On 7/7/22 10:27, David Marchand wrote:
> Hi Greg,
>
> On Wed, Jul 6, 2022 at 11:57 PM Gregory Rose <[email protected]> wrote:
>> On 7/6/2022 9:57 AM, Greg Rose wrote:
>>> It is time to remove support for the OVS kernel driver and push
>>> towards use of the upstream Linux openvswitch kernel driver
>>> in it's place [1].
>>>
>>> There are many Linux specific source modules in the datapath that
>>> will need eventual removal but some headers are still required for
>>> the userspace code (which seems counterintuitive but...)
>
> The easier would be to move the current copy we have in the datapath/
> under the include/openvswitch/ directory.
> Am I missing something else?
To my knowledge, there is only one header we need, which is:
datapath/linux/compat/include/linux/openvswitch.h
include/linux/ should be a good place for it. So,
git mv datapath/linux/compat/include/linux/openvswitch.h \
include/linux/openvswitch.h
git rm -r datapath
This header is not used directly, it's an input file for scripts
that generate include/odp-netlink.h, included by everything else,
and the datapath-windows/include/OvsDpInterface.h used in windows
datapath implementation. So, their build targets will need a
path adjustment after moving the header. See:
datapath-windows/include/automake.mk
include/automake.mk
Other than this one header, there is no code used by userspace
in datapath/ directory.
A few more lines will need to be removed from the Makefile.am,
as it seem to use the 'datapath' subdirectory still and requires
a few files from it via AC_CONFIG_SRCDIR/AC_CONFIG_FILES.
We also need to remove the modules_install target and clean up
the dist-hook-git target there.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
