https://bugzilla.redhat.com/show_bug.cgi?id=2398039
--- Comment #34 from Cristian Le <[email protected]> --- @[email protected] did you run fedora-review when you copied the licensecheck info in those headers? If not, please do. Here is the breakdown that I got from it ``` chatterino2: MIT AND BSD-3-Clause AND UNKNOWN!! AND {{ statically-linked dependencies (not yet reviewed) }} - Main is MIT - cmake/CodeCoverage.cmake: BSD-3-Clause (CMake helper only, does not propagate to binary, SourceLicense only) - lib/lrucache: BSD-3-Clause - src/providers/twitch/ChatterinoWebSocketppLogger.hpp: BSD-3-Clause (not in resources/licenses afaict) - semver/include/semver/semver.hpp: MIT - lib/twitch-eventsub-ws: UNKNOWN!! (@[email protected] please confirm) - resources/*: MIT (resources/contributors.txt has the details, unclear if they still own the copyright or surrendered it, assume former unless specified otherwise) libcommuni: BSD-3-Clause - Main is BSD-3-Clause settings: MIT - Main is MIT - cmake/conan_provider.cmake: MIT (CMake helper only, does not propagate to binary, SourceLicense only) signals: MIT - Main is MIT - cmake/conan_provider.cmake: MIT (CMake helper only, does not propagate to binary, SourceLicense only) serialize: MIT - Main is MIT magic_enum: MIT - Main is MIT - cmake/GenPkgConfig: UNLICENSE (CMake helper only, does not propagate to binary, SourceLicense only) certify: BSL-1.0 - Main is BSL-1.0 expected-lite: BSL-1.0 - Main is BSL-1.0 ``` Unless it is specified, please consider the licenses as joined by `AND` instead of `OR`, the latter has too much of a nuanced meaning to it. In some cases I added duplicate license because they are different copyright holders, but I didn't check all of them (man I wish they would just use spdx format and we could automate the copyright holders) @[email protected], your licenses in `resources/licenses` are out-of-date. Could you do an independent review on your side as well and compare with our review to see if we all agree and didn't miss anything? Note that you only need to add the licenses if you link statically, so it would be nice if there was some logic to filter based on how this is built. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2398039 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202398039%23c34 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
