https://bugzilla.redhat.com/show_bug.cgi?id=2398039
--- Comment #35 from Rasmus Karlsson <[email protected]> --- In our precaution (and lack of knowledge), we've included & attributed the license of every dependency we directly include, regardless of if it's a header only library, statically linked, or shared linked. Licenses for certify and pajlada/serialize are being fixed in https://github.com/Chatterino/chatterino2/pull/6575 src/providers/twitch/ChatterinoWebSocketppLogger.hpp uses the same license as websocketpp, whose license we have included under resources/licenses/websocketpp.txt, and is already included in our About page. lib/twitch-eventsub-ws is not an external library, but another module of Chatterino (it lives in the same repo, no submoduling), so licensed under the same Chatterino license. We could include the same license in that directory if that would help clarify things. resources/avatars contains the github avatar of contributors resources/{buttons,scrolling,settings,sounds,split,switcher,themes,automod} contains buttons/icons used in the app and are made by https://github.com/microsoft/fluentui-system-icons (we've included their licenses under resources/licenses and in our About page), by Chatterino contributors, or Twitch-owned badges used (as far as I know) in accordance to Twitch's developer agreement. resources/examples contains some videos used as tutorials for the applications, made by us. resources/licenses contains licenses of any asset/library we use resources/qss contains stylesheet for Chatterino, made by us resources/raw contain images & icons that are not included in Chatterino, but that we use to generate images that we use resources/contributors.txt contain a list of users who have helped contribute to Chatterino. We don't ask contributors to sign any CLA, so each contributor still owns their contributions, but the contributors.txt list is not complete. Our git commit history would be the closest we can get to a full "who technically owns what code" list. resources/emoji.json is a list of emojis / emoji sets & their capabilities. We attribute this and the emoji sets we include inside our About page. The rest of the included licenses are included correctly as far as I could tell, with the only thing I could see being wrong is technically the copyright year has been updated in some upstreams, which we haven't updated in a while. > Note that you only need to add the licenses if you link statically, so it > would be nice if there was some logic to filter based on how this is built. Do header-only libraries fall under the same category as statically linked libraries for the purpose of licenses you need to include? We could make this a little bit easier by adding a comment to the top of each license file in resources/licenses/ with information about how we use it, i.e. whether the license covers assets, it's a header only library, statically linked, or shared linked. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2398039 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202398039%23c35 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
