https://bugzilla.redhat.com/show_bug.cgi?id=2398039
--- Comment #39 from Cristian Le <[email protected]> --- > I have not. I am working under the assumption that emojis (i.e. the bytes to > emoji translation) was free to use without any crediting / attribution, while > emoji images (e.g. from the google emoji set we allow users to select) > require attribution. For reference, where I had that experience is when packagcing unicode-properties [1], and they also do not use the emoji art itself there [2]. Can't say I have more insight on it, other than, this is an unexpected license edge-case for me as well. > so confirming the license it will be : MIT AND BSD-3-Clause AND BSL-1.0 Yep, sounds about right, but be more explicit in the license breakdown, e.g. `lib/lrucache` should also be listed since it can be de-bundled. I think this is almost good to go, just a few more tasks: - Correct the license notes - Replace `g++` with `gcc-c++` - `doxygen` is not a requirement, let's avoid it - Please avoid wildcards if they are not needed, e.g. `%{_metainfodir}/*.xml` And just a modernization tip on how to make it more compact with %forgemeta `` %global forgeurl0 https://github.com/Chatterino/chatterino2 %global version0 2.5.4 %global date 20251110 %global commit0 f3559280786dbabc8cebe1951a525580d11cb2a5 %forgemeta -a Name: span Version: %forgeversion Release: %autorelease ``` The order of `%forgemeta` and `%autorelease` here makes it avoid any duplicate information, and `%forgeversion` takes care of all the version formatting for you. You can use `-p` to mark it as a pre-release, but I don't believe you want it in this case. Please also make a comment on why you take a snapshot. Most likely you can drop it or pick it back up as you need to with minimal diff. You do not need to use the full sha for the `commit<n>`, you can just use the short one and avoid an additional variable. `` %prep # Unpack the main source archive and the secondary sources # into separate directories in %%{_builddir}. # Then, switch into the unpacked Source0 directory. %setup -q %{forgesetupargs0} -b2 -b3 -b4 -b5 -b9 -b11 -b12 %autopatch -p1 mv %{_builddir}/%{topdir2} lib/libcommuni mv %{_builddir}/%{topdir3} lib/settings mv %{_builddir}/%{topdir4} lib/signals mv %{_builddir}/%{topdir5} lib/serialize mv %{_builddir}/%{topdir9} lib/magic_enum mv %{_builddir}/%{topdir11} lib/expected-lite mv %{_builddir}/%{topdir12} lib/certify ``` This one I took from openmw, haven't personally used it myself, but I like how it already does the extraction. Might not have the setup quite right, but play around with it as desired. And if you have a script that you think you could use for updating the submodules, please include it here for review. If you don't have any, that is ok, I will share mine with the devel channel once I get to it. [1]: https://github.com/unicode-rs/unicode-properties/ [2]: https://github.com/unicode-rs/unicode-properties/blob/558c2bf2a7218210218b861f416ec0bda9a7747b/scripts/unicode.py#L13-L17 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2398039 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202398039%23c39 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
