https://bugzilla.redhat.com/show_bug.cgi?id=2418764
Adam Williamson <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #7 from Adam Williamson <[email protected]> --- if you're skipping the tests, it doesn't really make sense to include BuildRequires for them, I don't think. You should at least include the minimal import check test - https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#pyproject_check_import . At least according to the docs, %pyproject_buildrequires is supposed to include runtime requirements: "-r: Include run-time requirements (this flag is not needed and exists for backward-compatibility reasons only, run-time requirements are included by default)." Does it not find those three run-time dependencies? If not, I wonder why not... aside from that this looks fairly good to me, but I'm not a sponsor so I can't sponsor you unfortunately. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2418764 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202418764%23c7 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
