https://bugzilla.redhat.com/show_bug.cgi?id=2418764
Jayaraj J <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?([email protected] | |om) | |needinfo?([email protected] | |om) --- Comment #9 from Jayaraj J <[email protected]> --- Spec URL: https://gitlab.com/jyrj/python-fastapi-pagination/-/raw/main/python-fastapi-pagination.spec SRPM URL: https://gitlab.com/jyrj/python-fastapi-pagination/-/raw/main/python-fastapi-pagination-0.15.1-1.fc43.src.rpm Description: FastAPI Pagination provides easy, extensible pagination for FastAPI applications with support for multiple ORMs and async DB layers. Fedora Account System Username: jyrj [fedora-review-service-build] --- @[email protected] Thank you for the initial review. @[email protected] Thank you for the detailed and extremely educational feedback. I have updated the package accordingly. Please let me know if further adjustments are needed. ✔ Changes made in response to review comments - Removed manual runtime dependencies; now relying entirely on the dependencies generated by %pyproject_buildrequires (per MUST/SHOULD NOT guidelines). - Added the required smoke test using %pyproject_check_import, as mandated by the Python Packaging Guidelines. - Updated naming: Main package: python-fastapi-pagination Subpackage: python3-fastapi-pagination Following the library naming guidelines (underscores → dashes). - Unified descriptions for both packages via a shared macro. - Replaced manual changelog entries with %autochangelog. - Removed redundant BuildRequires: pyproject-rpm-macros since python3-devel already provides the macros. - Added -p1 to %autosetup as suggested. - Added -l to %pyproject_save_files so license handling is automatic. - Added extras support: %pyproject_extras_subpkg -n python3-fastapi-pagination sqlalchemy (Only SQLAlchemy is enabled because other extras depend on packages not yet available in Fedora.) - Did not create extras subpackages for missing dependencies (databases, sqlakeyset, tortoise, odmantic, etc.) to avoid generating broken metapackages. - Verified the package builds cleanly in mock (rawhide-x86_64) with all checks passing. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2418764 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202418764%23c9 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
