https://bugzilla.redhat.com/show_bug.cgi?id=2480195
--- Comment #12 from Soren Soe <[email protected]> --- (In reply to Tom.Rix from comment #11) > I am going through the new specfile looking for changes I requested. > This request was not changed. > > > Patch0: 6.18.patch > > Patch1: 6.19.patch > > > Patches should have a comment on what the patch does and if possible > > reference the upstream issue or pr > > this is a general problem. > > I find using git format patches more helpful as any updated to the package > > will require rebasing. > > consider reworking these patches to be git friendly. > > Consider using this prompt to generate the comments, and for you to verify > them > https://fedoraproject.org/wiki/SIGs/AI-ML#Adding_comments_to_specfile_patches The linked spec has been updated with patch comments. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2480195 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202480195%23c12 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
