https://bugzilla.redhat.com/show_bug.cgi?id=2480195



--- Comment #15 from [email protected] ---
When updating the spec and srpm, it is necessary to add the tags
Spec URL: <something>
SPRM URL: <somethign>

everytime, this triggers the automatic fedora reviewer and lets the reviewer
know where the update is.
going with maybe the correct url from above, i get these errors

- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE.aie-rt is not marked as %license
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/LicensingGuidelines/#_license_text

Please fix

- Sources used to build the package match the upstream source, as provided
  in the spec URL.
  Note: Upstream MD5sum check error, diff is in /sfs/fedora-
  review/xrt/review-xrt/diff.txt
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/

This is important. make sure the upstream IS what is in the src tarball
Anything not needed from the upstream src tarball can be rm-ed in %prep.

[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Apache License 2.0", "Apache License
     2.0 and/or GNU General Public License, Version 2", "Khronos License",
     "MIT License", "GNU General Public License, Version 2", "Apache
     License 2.0 and/or GNU General Public License v2.0 or later [obsolete
     FSF postal address (Temple Place)]", "*No copyright* MIT License",
     "BSD 3-Clause License", "*No copyright* Apache License 2.0", "Apache
     License". 144 files have unknown license. Detailed output of
     licensecheck in /sfs/fedora-review/xrt/review-xrt/licensecheck.txt

Has several licenses that are not in 

License:        Apache-2.0 AND MIT

All the licenses need to be in the License: field.
If something is not really needed and it would simplify the license, rm it in
%prep

xrt-debuginfo.x86_64: W: invalid-license Khronos


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2480195

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202480195%23c15

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to