https://bugzilla.redhat.com/show_bug.cgi?id=2480195
--- Comment #13 from [email protected] --- This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Look at xrt/README.rst .. image:: https://travis-ci.org/Xilinx/XRT.svg?branch=master :target: https://travis-ci.org/Xilinx/XRT These links are broken. Why do subproject carry their own licenses ? Why not combine -utils into the main and npu packages ? Otherwise, this naming is awkward -npu and -utils-npu, should be -npu and -npu-utils mv -f %{buildroot}%{_prefix}/python/xbtop.py %{buildroot}%{_bindir}/xbtop 2>/dev/null || : mv -f %{buildroot}%{python3_sitearch}/xbtop.py %{buildroot}%{_bindir}/xbtop 2>/dev/null || : Why 2 commands? remove the wrong one. Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE.aie-rt is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'Apache-2.0 AND MIT AND Khronos'. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Maybe https://spdx.org/licenses/MIT-Khronos-old.html - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /sfs/fedora- review/xrt/review-xrt/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Apache License 2.0", "Apache License 2.0 and/or GNU General Public License, Version 2", "Khronos License", "MIT License", "GNU General Public License, Version 2", "Apache License 2.0 and/or GNU General Public License v2.0 or later [obsolete FSF postal address (Temple Place)]", "*No copyright* MIT License", "BSD 3-Clause License", "*No copyright* Apache License 2.0", "Apache License". 144 files have unknown license. Detailed output of licensecheck in /sfs/fedora-review/xrt/review-xrt/licensecheck.txt [!]: License file installed when any subpackage combination is installed. See question about License: in the subpackages above. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/python3.15/site- packages, /usr/lib/.build-id/fc, /usr/lib64/python3.15 known problem. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [!]: Sources contain only permissible code or content. ELF binaries found in upstream tarball: 1. .../aie-rt/driver/tests/utest/elf_files/aieml_elfs/passthrough 2. .../aie-rt/driver/tests/utest/elf_files/aie_elfs/passthrough 3. .../aie-rt/driver/tests/utest/elf_files/aie_elfs/overlap_elf 4. .../aie-rt/driver/tests/utest/elf_files/aie_elfs/large_elf 5. .../aie-rt/driver/tests/utest/elf_files/aie_elfs/mmul Remove these in %prep [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 9014 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. same as below [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in xrt-npu , python3-xrt , xrt-utils , xrt-utils-npu , xrt-utils-alveo [x]: Package functions as described. [x]: Latest version is packaged. [!]: Package does not include license text files separate from upstream. license.patch You can not in the package change the license of the upstream source. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. See earlier comment in bz. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: xrt-2.21.75-1.fc45.x86_64.rpm xrt-npu-2.21.75-1.fc45.x86_64.rpm python3-xrt-2.21.75-1.fc45.x86_64.rpm xrt-devel-2.21.75-1.fc45.x86_64.rpm xrt-utils-2.21.75-1.fc45.x86_64.rpm xrt-utils-npu-2.21.75-1.fc45.x86_64.rpm xrt-utils-alveo-2.21.75-1.fc45.x86_64.rpm xrt-2.21.75-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp6hw171r9')] checks: 32, packages: 8 xrt-utils.x86_64: W: non-conffile-in-etc /etc/OpenCL/vendors/amdxrt.icd python3-xrt.x86_64: W: no-manual-page-for-binary xbtop xrt-utils.x86_64: W: no-manual-page-for-binary xrt-smi xrt-utils-alveo.x86_64: W: no-manual-page-for-binary xbflash.qspi xrt-utils-npu.x86_64: W: no-manual-page-for-binary xrt-runner python3-xrt.x86_64: W: no-documentation xrt-devel.x86_64: W: no-documentation xrt.src: W: invalid-license Khronos xrt.x86_64: W: invalid-license Khronos xrt-devel.x86_64: W: invalid-license Khronos xrt-utils.x86_64: W: invalid-license Khronos xrt-utils-alveo.x86_64: W: invalid-license Khronos xrt-utils-npu.x86_64: W: invalid-license Khronos 8 packages and 0 specfiles checked; 0 errors, 13 warnings, 78 filtered, 0 badness; has taken 31.3 s Rpmlint (debuginfo) ------------------- Checking: xrt-utils-npu-debuginfo-2.21.75-1.fc45.x86_64.rpm xrt-npu-debuginfo-2.21.75-1.fc45.x86_64.rpm xrt-debuginfo-2.21.75-1.fc45.x86_64.rpm xrt-utils-alveo-debuginfo-2.21.75-1.fc45.x86_64.rpm xrt-utils-debuginfo-2.21.75-1.fc45.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpx7rops2l')] checks: 32, packages: 5 xrt-debuginfo.x86_64: W: invalid-license Khronos xrt-utils-alveo-debuginfo.x86_64: W: invalid-license Khronos xrt-utils-debuginfo.x86_64: W: invalid-license Khronos xrt-utils-npu-debuginfo.x86_64: W: invalid-license Khronos 5 packages and 0 specfiles checked; 0 errors, 4 warnings, 64 filtered, 0 badness; has taken 6.4 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 12 xrt-utils.x86_64: W: non-conffile-in-etc /etc/OpenCL/vendors/amdxrt.icd xrt-utils-npu.x86_64: W: no-manual-page-for-binary xrt-runner xrt-utils.x86_64: W: no-manual-page-for-binary xrt-smi xrt-utils-alveo.x86_64: W: no-manual-page-for-binary xbflash.qspi python3-xrt.x86_64: W: no-manual-page-for-binary xbtop xrt-devel.x86_64: W: no-documentation python3-xrt.x86_64: W: no-documentation xrt.x86_64: W: invalid-license Khronos xrt-devel.x86_64: W: invalid-license Khronos xrt-utils-npu.x86_64: W: invalid-license Khronos xrt-utils-npu-debuginfo.x86_64: W: invalid-license Khronos xrt-utils-alveo-debuginfo.x86_64: W: invalid-license Khronos xrt-utils.x86_64: W: invalid-license Khronos xrt-utils-alveo.x86_64: W: invalid-license Khronos xrt-utils-debuginfo.x86_64: W: invalid-license Khronos xrt-debuginfo.x86_64: W: invalid-license Khronos 12 packages and 0 specfiles checked; 0 errors, 16 warnings, 158 filtered, 0 badness; has taken 5.4 s Unversioned so-files -------------------- python3-xrt: /usr/lib64/python3.15/site-packages/pyxrt.cpython-315-x86_64-linux-gnu.so Source checksums ---------------- https://github.com/Xilinx/XRT/releases/download/2.21.75/2.21.75.tar.gz#/xrt-2.21.75.tar.gz : CHECKSUM(SHA256) this package : 299c15e991034f2f32adadd03ac912d6ef8d4bad3a99db632bd17c7a25dbaf6e CHECKSUM(SHA256) upstream package : 30343a3c74103ac5d5016525d6f051601b197855c54e980f8d6623bfc6f3d229 diff -r also reports differences Requires -------- xrt (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgcc_s.so.1(GCC_3.4)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libuuid.so.1()(64bit) libuuid.so.1(UUID_1.0)(64bit) libxrt++.so.2()(64bit) libxrt_coreutil.so.2()(64bit) rtld(GNU_HASH) xrt-npu (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libuuid.so.1()(64bit) libuuid.so.1(UUID_1.0)(64bit) libxdp_core.so.2()(64bit) libxrt_core.so.2()(64bit) libxrt_coreutil.so.2()(64bit) rtld(GNU_HASH) xrt(x86-64) python3-xrt (rpmlib, GLIBC filtered): /usr/bin/python3 libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libuuid.so.1()(64bit) libuuid.so.1(UUID_1.0)(64bit) libxrt_coreutil.so.2()(64bit) python(abi) python3(x86-64) rtld(GNU_HASH) xrt(x86-64) xrt-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cmake-filesystem libuuid-devel libxilinxopencl.so.2()(64bit) libxrt++.so.2()(64bit) libxrt_core.so.2()(64bit) libxrt_coreutil.so.2()(64bit) libxrt_hip.so.2()(64bit) opencl-headers python3-xrt(x86-64) rocm-hip-devel(x86-64) xrt(x86-64) xrt-npu(x86-64) xrt-utils (rpmlib, GLIBC filtered): libboost_filesystem.so.1.90.0()(64bit) libboost_program_options.so.1.90.0()(64bit) libc.so.6()(64bit) libcrypto.so.4()(64bit) libcrypto.so.4(OPENSSL_4.0.0)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libuuid.so.1()(64bit) libuuid.so.1(UUID_1.0)(64bit) libxrt_coreutil.so.2()(64bit) opencl-filesystem python3(x86-64) rtld(GNU_HASH) xrt(x86-64) xrt-utils-npu (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libxrt_coreutil.so.2()(64bit) rtld(GNU_HASH) xrt-npu(x86-64) xrt-utils(x86-64) xrt-utils-alveo (rpmlib, GLIBC filtered): libboost_program_options.so.1.90.0()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libxrt_coreutil.so.2()(64bit) rtld(GNU_HASH) xrt-utils(x86-64) Provides -------- xrt: libxilinxopencl.so.2()(64bit) libxrt++.so.2()(64bit) libxrt_core.so.2()(64bit) libxrt_coreutil.so.2()(64bit) libxrt_hip.so.2()(64bit) xrt xrt(x86-64) xrt-npu: libxdp_aie_profile_plugin.so.2()(64bit) libxdp_aie_trace_plugin.so.2()(64bit) libxdp_core.so.2()(64bit) libxdp_ml_timeline_plugin.so.2()(64bit) libxdp_native_plugin.so.2()(64bit) libxdp_user_plugin.so.2()(64bit) libxrt_driver_xdna.so.2()(64bit) xrt-npu xrt-npu(x86-64) python3-xrt: python-xrt python3-xrt python3-xrt(x86-64) python3.15-xrt xrt-devel: cmake(xrt) pkgconfig(xrt) xrt-devel xrt-devel(x86-64) xrt-utils: xrt-utils xrt-utils(x86-64) xrt-utils-npu: xrt-utils-npu xrt-utils-npu(x86-64) xrt-utils-alveo: xrt-utils-alveo xrt-utils-alveo(x86-64) Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -n xrt Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, C/C++, Shell-api Disabled plugins: PHP, R, Haskell, Perl, SugarActivity, fonts, Java, Ocaml Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2480195 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202480195%23c13 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
