https://bugzilla.redhat.com/show_bug.cgi?id=2480195



--- Comment #16 from Soren Soe <[email protected]> ---
Not sure what I should do with the license comment?

The spec has:
%files
%license %{_licensedir}/%{name}/*
%license %{_licensedir}/%{name}-npu/*

which covers license.aie-rt as installed
%install
...
install -pm 0644 xrt/XRT/src/runtime_src/aie-rt/license.txt \
   %{buildroot}%{_licensedir}/%{name}/LICENSE.aie-rt

As for the MD5, I had to repackage the upstream release tar-ball with a
top-level directory prior to rpmbuild, thus the SRPM contains the repackaged
tar-ball. Not sure how I ran into the problem that forced me to repackage? 
This will be moot in next release where the upstream release tar-ball contains
the top-level dir. 

For licenses, what do I do about dual licensed files where only one license is
application for user space code and thus the packages created here?

Also, %prep has removed unused files that completely eliminates Khronos, but
XRT/NOTICE still references it as XRT (without prep) includes software from
Khronos.  How do I deal with this situation?  

The license review complains about a lot of files, but these have been remedied
in the spec explicitly. 

I updated the to license to include GPL-2.0-only, but in reality the files with
GPL-2 are dual licensed as Apache-2.0.

Spec URL:
https://raw.githubusercontent.com/stsoe/XRT-DEBIAN/2.21.75/src/fedora/xrt.spec
SRPM URL:
https://raw.githubusercontent.com/stsoe/XRT-DEBIAN/2.21.75/src/fedora/xrt-2.21.75-1.fc44.src.rpm


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2480195

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202480195%23c16

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to