https://bugzilla.redhat.com/show_bug.cgi?id=2523675
Petr Menšík <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Petr Menšík <[email protected]> --- Found inside by coincidence bundled src-core/nlohmann directory. It seems it contains the same version I have on F43: json-devel-3.11.3-4.fc43.x86_64 vs bundled . If it could be compiled with system provided instance, that should be used instead. But the core core seem to use relative includes only. Some effort should be tried to test, whether it can work with packaged json package. It must declare bundled version in any case. There seem to be more bundled external projects: - https://github.com/ocornut/imgui in src-core/imgui (osgearth package might contain a copy of it already) It also uses src-core/libs and bundles it into the build. It seems unconditional in src-core/CMakeLists.txt, variable GLOB_RECURSE. Suspicious are: - jpeg - jpeg12 - bzlib (bzip2/libbzip2 version 1.1.0 of 6 September 2010 !) - calceph - supernovas - miniz - muparser - rapidxml.hpp is provided also by boost-devel. Not sure it is compatible. I think some effort should be done to use system packages, because there often are matching ones. If they cannot replaced by the system provided files, they MUST be marked by 'bundled(X)' Provides. I think every lib used from src-core/libs should be mentioned, if not unbundled. Especially if it has some LICENSE file inside, which identifies it as a separate project. if they are unmodified, maybe deleting bundled subdirectories and replacing them with symlinks could work often. It should mention explicitly in spec, when some bundled dependency is necessary and difficult to replace with a system package. A lot of those bundles are missing in Fedora. I have not found any suspicious license among them (have not tried really hard), that is good. Otherwise the package is good. and spec is nice. Appstream XML verification is added already. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2523675 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202523675%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
