https://bugzilla.redhat.com/show_bug.cgi?id=2523675
--- Comment #5 from Jaroslav Škarvada <[email protected]> --- Upstream comment on it (https://github.com/SatDump/SatDump/issues/1196#issuecomment-5416738425): > I read up on that review request and notice there were talks of not using > bundled libraries. Please don't do that. There's a reason I bundle things > when I do and don't use/want to let CMake find system libraries. Many bundled > libraries are also modified in order to do what I needed. > > It also guarantees that since I often rely on specific versions (with > specific behavior) things don't randomly break unexpectedly. > > So my answer there would to declared them as bundled in the package as > suggested, and please don't touch this, you'll break things even if it may be > hard to notice at first. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2523675 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202523675%23c5 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
