https://bugzilla.redhat.com/show_bug.cgi?id=2523675



--- Comment #8 from Ben Beasley <[email protected]> ---
A couple of other things from a quick glance at the spec file:

----

> %{_libdir}/lib*.so.*

To avoid undetected ABI-breaking updates, don’t glob over the SONAME version.

https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files

----

You need to enumerate *all* of the licenses in the software, including those
for bundled dependencies, not just the “top-level” one, and include them in the
License field, ideally with a comment breaking down which licenses apply to
what. See
https://docs.fedoraproject.org/en-US/legal/license-field/#_no_effective_license_analysis
and
https://docs.fedoraproject.org/en-US/legal/license-field/#_more_complex_example.
You also need to make sure that there aren’t any missing mandatory license
texts for bundled dependencies; see
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text.
All of this can be quite a bit of work for a package with many bundled
dependencies and bits of code copied from here and there (as I well know from
experience), but it’s required.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2523675

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202523675%23c8

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to