https://bugzilla.redhat.com/show_bug.cgi?id=2523675
--- Comment #7 from Ben Beasley <[email protected]> --- (In reply to Jaroslav Škarvada from comment #5) > Upstream comment on it > (https://github.com/SatDump/SatDump/issues/1196#issuecomment-5416738425): > > I read up on that review request and notice there were talks of not using > > bundled libraries. Please don't do that. There's a reason I bundle things > > when I do and don't use/want to let CMake find system libraries. Many > > bundled libraries are also modified in order to do what I needed. This seems like an adequate justification for using bundled libraries, particularly the fact that many bundled libraries have been forked, even if it’s unfortunate (https://fedoraproject.org/wiki/Bundled_Libraries#Why_Bundled_Libraries_are_a_problem). You can also link that comment for the requirement to publicly contact upstream about a path to using system libraries. You still need to make sure you have identified all of the bundled dependencies and documented them with virtual Provides. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2523675 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202523675%23c7 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
