Robert,
Some more thoughts about the changes to libpfm for AMD64: - You introduce a change in the libpfm API where the event table may contain more events than you can actually use on the host PMU. For all other PMUs, the table is adjusted for the host PMU and all events are available. With your change, iterating over the list of events or asking for info about an event using an index may fail despite the fact that the index is within the valid range. - You have fixed certain libpfm calls to handle the case where the AMD64 specific code hits an unsupported event. However, there are a few leftovers, such as pfm_get_event_description(), pfm_get_event_mask_description(). With this change, all calls which take an event descriptor must be checked. - I am wondering if it would not be cleaner to build (on-the-fly) an event-table that would be tailored to the host PMU. It may be difficult to build the table but this is done once at initialization of the library. What do you think? ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ perfmon2-devel mailing list perfmon2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/perfmon2-devel
