On Tue, Jun 06, 2023 at 08:05:49AM +0530, Amit Kapila wrote: > Personally, I don't see any problem to do this refactoring for v16. > However, sometimes, we do decide to backpatch refactoring in tests to > avoid backpatch effort. I am not completely sure if that is the case > here.
033_replay_tsp_drops.pl has one find_in_log() down to 11, and 019_replslot_limit.pl has four calls down to 14. Making things consistent everywhere is a rather appealing argument to ease future backpatching. So I am OK to spend a few extra cycles in adjusting these routines all the way down where needed. I'll do that tomorrow once I get back in front of my laptop. Note that connect_ok() and connect_fails() are new to 14, so this part has no need to go further down than that. -- Michael
signature.asc
Description: PGP signature
