On Mon, Jun 5, 2023 at 9:39 PM vignesh C <vignes...@gmail.com> wrote: > > On Sun, 4 Jun 2023 at 03:51, Michael Paquier <mich...@paquier.xyz> wrote: > > > > This looks like a typo to me, the log offset is eaten. > > > > Except of that, I am on board with log_contains(). > > Thanks for fixing this.
+1 for deduplicating find_in_log. How about deduplicating advance_wal too so that 019_replslot_limit.pl, 033_replay_tsp_drops.pl, 035_standby_logical_decoding.pl and 001_stream_rep.pl can benefit immediately? FWIW, a previous discussion related to this is here https://www.postgresql.org/message-id/flat/CALj2ACVUcXtLgHRPbx28ZQQyRM6j%2BeSH3jNUALr2pJ4%2Bf%3DHRGA%40mail.gmail.com. -- Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com