On Fri, Jun 9, 2023 at 8:29 AM Michael Paquier <mich...@paquier.xyz> wrote: > > On Tue, Jun 06, 2023 at 05:53:40PM +0530, Bharath Rupireddy wrote: > > Yes. A simpler way of doing it would be to move advance_wal() in > > 019_replslot_limit.pl to Cluster.pm, something like the attached. CI > > members don't complain with it > > https://github.com/BRupireddy/postgres/tree/add_a_function_in_Cluster.pm_to_generate_WAL. > > Perhaps, we can name it better instead of advance_wal, say > > generate_wal or some other? > > Why not discussing that on a separate thread? What you are proposing > is independent of what Vignesh has proposed.
Sure. Here it is - https://www.postgresql.org/message-id/CALj2ACU3R8QFCvDewHCMKjgb2w_-CMCyd6DAK%3DJb-af14da5eg%40mail.gmail.com. > Note that the patch > format is octet-stream, causing extra CRs to exist in the patch. > Something happened on your side when you sent your patch, I guess? Had to attach the patch in .txt format to not block Vignesh's patch from testing by CF Bot (if at all this thread was added there). -- Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
