On Tue, Jun 06, 2023 at 05:53:40PM +0530, Bharath Rupireddy wrote: > Yes. A simpler way of doing it would be to move advance_wal() in > 019_replslot_limit.pl to Cluster.pm, something like the attached. CI > members don't complain with it > https://github.com/BRupireddy/postgres/tree/add_a_function_in_Cluster.pm_to_generate_WAL. > Perhaps, we can name it better instead of advance_wal, say > generate_wal or some other?
Why not discussing that on a separate thread? What you are proposing is independent of what Vignesh has proposed. Note that the patch format is octet-stream, causing extra CRs to exist in the patch. Something happened on your side when you sent your patch, I guess? -- Michael
signature.asc
Description: PGP signature
