On Sun, Jun 17, 2018 at 10:57:16AM -0400, Tom Lane wrote: > If we're just leaving them undefined, isn't this purely cosmetic? > At least, that was what I understood to be the reasoning for leaving > such symbols out of pg_config.h.win32 in the past. > > I'm on board with making things more consistent in HEAD, but not sure > I see any need for back-patching.
I think that it is also important to give to those flags some visibility so as packagers can more easily find what to switch on/off when they come across compilation failures with a given version of OpenSSL, so that's also a matter of documenting things. You are right that as the number of people doing packaging on Windows for Postgres can perhaps be counted with the fingers of both hands, that may not be worth bothering. I maintain such stuff by the way, so this counts as one finger up. As there is visibly a consensus for HEAD, for now I propose to just process with the previous patch on only the master branch then. This will address the open item. Any objections to that? -- Michael
signature.asc
Description: PGP signature
