On Mon, Jul 22, 2024 at 8:26 AM Hayato Kuroda (Fujitsu) <kuroda.hay...@fujitsu.com> wrote: > > ``` > @@ -1089,6 +1089,12 @@ CheckAlterSubOption(Subscription *sub, const char > *option, > * is because both failover and two_phase options of the slot on the > * publisher cannot be modified if the slot is currently acquired by the > * existing walsender. > + * > + * XXX: when toggling two_phase from "false" to "true", the slot > parameter > + * is not modified by the backend process so that the lock conflict won't > + * occur. The restarted walsender will do the alternation. Therefore, we > + * can allow to switch without the restriction. This can be changed in > + * the future based on the requirement. > ``` > >
I used a slightly different comment in the attached. Apart from this, I also addressed comments by Vignesh and Peter. Let me know if I missed anything. -- With Regards, Amit Kapila.
v22-0001-Allow-altering-of-two_phase-option-for-a-SUBSCRI.patch
Description: Binary data
