On Wed, Apr 9, 2025 at 8:08 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Wed, Apr 9, 2025 at 7:48 AM Peter Smith <smithpb2...@gmail.com> wrote: > > > > I was looking at the recent push for the pg_createsubscription "--all" > > option [1], because I was absent for several weeks prior. > > > > I found some minor non-functional issues as follows: > > > > ====== > > doc/src/sgml/ref/pg_createsubscriber.sgml > > ~ > > > > 1c. > > I didn't think the sentence quite belongs here because it isn't > > describing anything about the --all option. Instead, it is describing > > how the source server connection is made. > > > > This sentence describes how we connect when --all option is used. For > other cases, see the description in the -d option. So, this change is > not required. If you agree, then you can combine the other two > patches, and we can proceed with those. >
OK. Here is a single patch which combines previous patches 0001 and 0003. ====== Kind Regards, Peter Smith. Fujitsu Australia
v20250410-0001-Fix-DOCS-and-code-comment-for-option-all.patch
Description: Binary data