Hi Ian Thanks for the patch! Here a few comments on v2:
== shadow variable == The function pg_get_event_trigger_ddl_internal has a bool parameter named owner, and its body has a char* with the same name. == trailing XXX (placeholder?) == + * CREATE EVENT TRIGGER statement; XXX == typo (2x the) == + is false, the the corresponding <literal>ENABLE</literal> clause is === switch without default == I realise that "switch (evtForm->evtenabled)" already tests all possible values of evtenable, but I'm wondering if we really should let it silently finish the buffer like "ALTER EVENT TRIGGER foo ;" if evtenable ever gets a different value. I'd argue that an error message would be better than a malformed DDL. What do you think? Best, Jim
