Hi Tatsuo,

> execRPR.c:1361:14: error: unused variable 'pattern'
[-Werror,-Wunused-variable]
>  1361 |         RPRPattern *pattern = winstate->rpPattern;
>       |                     ^~~~~~~

That is nfa_advance_var()'s local.  Only an Assert reads it, so a
build without --enable-cassert leaves it unused.  Our own builds all
have cassert on, which is why it never showed up locally.

In the increment, nocfbot-2013-executor-reads-own-state.txt drops the
local and has the Assert read winstate->rpPattern directly:

  Assert(elem->next >= 0 &&
         elem->next < winstate->rpPattern->numElements);

It is an error that arose partway through the increment, so fixing it
is right.  2013 settles it.

>From here on I will run the build and the tests against a release
build as well.

Best regards,
Henson

Reply via email to