Hi Henson, Hi Jian, Since v51 "pg_nodiscard" has been introduced in the RPR patches for some static functions. Are these "pg_nodiscard" really necessary? I know that PostgreSQL already uses pg_nodiscard for some list functions and memory allocation functions etc. but there's no single instance of pg_nodiscard being used for static functions. I guess the reason is that because function declarations are in the same file as the callers, there's very small chance to mistakenly ignore the function's return value.
Regards, -- Tatsuo Ishii SRA OSS K.K. English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp
