On Sun, Aug 9, 2009 at 8:48 PM, Andrew Dunstan<and...@dunslane.net> wrote: > > > Andrew Dunstan wrote: >> >> >> Andres Freund wrote: >>>> >>>> BTW, has anyone tried validating the XML at all? I just looked very >>>> briefly at the patch at >>>> <http://archives.postgresql.org/pgsql-hackers/2009-07/msg01944.php> and >>>> I noticed this which makes me suspicious: >>>> >>>> + if (es.format == EXPLAIN_FORMAT_XML) >>>> + appendStringInfoString(es.str, >>>> + "<explain xmlns=\"http://www.postgresql.org/2009/explain\"; >>>> <http://www.postgresql.org/2009/explain%5C%22>;>\n"); >>>> >>> >>> That bug is fixed - as referenced above I wrote a schema and validated >>> it. So, yes, the generated XML was valid at least before the last round of >>> refactoring. And I looked through the output quite a bit so I would >>> surprised if there is such a breakage. >>> then someone needs to update the commitfest page with the lastest patch. >>> That's the link I followed. >>> >>> >>> >> >> Hmm. I wonder how i got the link to an old version of the patch. >> >> Anyway, I'm glad it's fixed. > > > I takle it back. It's still there at > <http://archives.postgresql.org/pgsql-hackers/2009-08/msg00485.php> posted 3 > days ago.
What the hell? I have every version of that patch I've ever submitted in ~/patch/explain-as-submitted, and that extra semicolon is not there in any of them. Furthermore, when I open up the attachment from my sent mail, the semicolon isn't there either. Yet I see it at the link you provided just as clearly as you do. Is there a bug in the archives code??? ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
