I was not previously able to answer fujii's all comments.
This is the remaining answers.

> +     LWLockAcquire(WALInsertLock, LW_EXCLUSIVE);
> +     XLogCtl->Insert.fullPageWrites = fullPageWrites;
> +     LWLockRelease(WALInsertLock);
> I don't think WALInsertLock needs to be hold here because there is no
> concurrently running process which can access Insert.fullPageWrites.
> For example, Insert->currpos and Insert->LogwrtResult are also changed
> without the lock there.


> The source comment of XLogReportParameters() needs to be modified.

Yes, too.

Jun Ishizuka
NTT Software Corporation

Sent via pgsql-hackers mailing list (
To make changes to your subscription:

Reply via email to