On Wed, Mar 9, 2016 at 9:09 AM, Masahiko Sawada
<sawada.m...@gmail.com> wrote: Attached latest 2 patches.
> * 000 patch : Incorporated the review comments and made rewriting
> logic more clearly.

That's better, thanks.  But your comments don't survive pgindent.
After running pgindent, I get this:

+               /*
+                * These old_* variables point to old visibility map page.
+                *
+                * cur_old        : Points to current position on old
page. blkend_old :
+                * Points to end of old block. break_old  : Points to
old page break
+                * position for rewriting a new page. After wrote a
new page, old_end
+                * proceeds rewriteVmBytesPerPgae bytes.
+                */

You need to either surround this sort of thing with dashes to make
pgindent ignore it, or, probably better, rewrite it using complete
sentences that together form a paragraph.

+       Oid                     pg_database_oid;        /* OID of
pg_database relation */

Not used anywhere?

Instead of vm_need_rewrite, how about vm_must_add_frozenbit?

Can you explain the changes to test.sh?

Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to