Fujii Masao wrote: > On Thu, Jun 30, 2016 at 9:30 PM, Michael Paquier > <michael.paqu...@gmail.com> wrote: > > On Thu, Jun 30, 2016 at 8:59 PM, Fujii Masao <masao.fu...@gmail.com> wrote:
> >> ISTM that we will never be able to get out of this loop if walreceiver > >> fails to connect to the master (e.g., password is wrong) after we enter > >> this loop. > > > > Wouldn't it be cleaner to just return an error here instead of retrying? > > I prefer to return NULL. Now NULL is returned when walreceiver's pid is 0. > We can just change this logic so that NULL is returned pid is 0 OR the > flag is false. For the conninfo only, or for everything? -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
