On Wed, Aug 24, 2016 at 11:15 PM, Stephen Frost <sfr...@snowman.net> wrote:
> * Michael Paquier (michael.paqu...@gmail.com) wrote:
>> The patch attached includes all those tests and they are failing. We
>> are going to need a patch able to pass all that, and even for master
>> this is going to need more thoughts, and let's focus on HEAD/9.6
>> first.
> Are you sure you have the tests correct..?   At least for testagg(), it
> looks like you're testing for:
> GRANT ALL ON FUNCTION test_agg(int2) TO regress_dump_test_role;
> but what's in the dump is (equivilantly):
> GRANT ALL ON FUNCTION test_agg(smallint) TO regress_dump_test_role;
> I've not looked into all the failures, but at least this one seems like
> an issue in the test, not an issue in pg_dump.

Yes, you are right. If I look at the diffs this morning I am seeing
the ACLs being dumped for this aggregate. So we could just fix the
test and be done with it. I did not imagine the index issue though,
and this is broken for some time, so that's not exclusive to 9.6 :)

Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to