On Mon, Nov 7, 2016 at 3:36 PM, Michael Paquier <michael.paqu...@gmail.com>

> On Mon, Nov 7, 2016 at 12:36 PM, Haribabu Kommi
> <kommi.harib...@gmail.com> wrote:
> > The added regression test fails for the cases where the server is loaded
> > with
> > different pg_hba.conf rules during installcheck verification. Updated
> patch
> > is
> > attached with removing those tests.
> That's not a full review as I just glanced at this patch a couple of
> seconds...
>  #include "utils/guc.h"
> +#include "utils/jsonb.h"
>  #include "utils/lsyscache.h"
> You don't need to include this header when using arrays.

Thanks for the review. Fixed in the updated patch with
additional error messages are also added.

> Implementing a test case is possible as well using the TAP
> infrastructure. You may want to look at it and help folks testing the
> patch more easily with a set of configurations in pg_hba.conf that
> cover a maximum of code paths in your patch.

Added a tap test under src/test folder to cover maximum code changes.

Hari Babu
Fujitsu Australia

Attachment: pg_hba_rules_tap_tests_1.patch
Description: Binary data

Attachment: pg_hba_rules_4.patch
Description: Binary data

Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to