On Fri, Jan 13, 2017 at 2:31 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Fri, Jan 13, 2017 at 2:18 PM, Alvaro Herrera > <alvhe...@2ndquadrant.com> wrote: >> Robert Haas wrote: >>> Fix a bug in how we generate partition constraints. >>> >>> Move the code for doing parent attnos to child attnos mapping for Vars >>> in partition constraint expressions to a separate function >>> map_partition_varattnos() and call it from the appropriate places. >> >> Hmm, we were discussing this stuff a few days ago, see >> https://www.postgresql.org/message-id/20170109182800.qrkae62kmur3gfeg@alvherre.pgsql >> and commit 3957b58b8885441c8d03bc1cfc00e47cf8cd7975. Part of this code >> duplicates that ... > > Is that bad?
If you are expressing a concern about who wrote this code, I took Amit's word for it that he did. His patch file says: Reported by: n/a Patch by: Amit Langote Reports: n/a If that ain't right, that's bad. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
