On Wed, Feb 8, 2017 at 8:58 AM, Dilip Kumar <dilipbal...@gmail.com> wrote: > On Wed, Feb 8, 2017 at 7:01 PM, Robert Haas <robertmh...@gmail.com> wrote: >> You can store whatever you want in SH_TYPE's private_data member. >> SH_ALLOCATE and SH_FREE both get a pointer to the SH_TYPE, so they >> have access to that. Hmm, but there's no way to get that set in >> SH_CREATE before SH_ALLOCATE is called. Maybe we need to add a >> private_data argument to SH_CREATE. execGrouping.c could use that >> instead of frobbing private_data directly: >> >> - hashtable->hashtab = tuplehash_create(tablecxt, nbuckets); >> - hashtable->hashtab->private_data = hashtable; >> + hashtable->hashtab = tuplehash_create(tablecxt, nbuckets, hashtable); > > Okay, will go ahead as you suggested. Patch attached for the same.
Looks good to me. If nobody has further ideas here, I'll push this and your previous patch tomorrow. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers