On Mon, May 15, 2017 at 9:59 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > + * > + * Returns -1 on failure, 0 if the socket is readable/writable, 1 if > it timed out. > */ > pqWait is internal to libpq, so we are free to set up what we want > here. Still I think that we should be consistent with what > pqSocketCheck returns: > * >0 means that the socket is readable/writable, counting things. > * 0 is for timeout. > * -1 on failure.
That would imply a lot more change, though. The way that the patch currently does it, none of the other callers of pqWait() or pqWaitTimed() need to be adjusted. So I prefer the way that Tsunakawa Takayuki currently has this over your proposal. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers