On 6/2/17 22:13, Peter Eisentraut wrote: > On 5/27/17 06:54, Petr Jelinek wrote: >> On 27/05/17 04:00, Euler Taveira wrote: >>> 2017-05-26 21:29 GMT-03:00 Petr Jelinek <petr.jeli...@2ndquadrant.com >>> <mailto:petr.jeli...@2ndquadrant.com>>: >>> >>> >>> Actually another possibility would be to remove the REFRESH keyword >>> completely and just have [ WITH (...) ] and have the refresh option >>> there, ie simplified version of what you have suggested (without the >>> ugliness of specifying refresh twice to disable). >>> >>> >>> It will cause confusion. It seems that WITH sets ALTER SUBSCRIPTION >>> properties. Indeed, they are REFRESH properties. I think we shouldn't >>> exclude REFRESH keyword. Syntax leaves no doubt that WITH are REFRESH >>> properties. >>> >> >> Maybe, I don't know, it might not be that confusing when SET PUBLICATION >> and REFRESH PUBLICATION have same set of WITH options. > > I'm not sure what the conclusion from the above discussion was supposed > to be, but here is a patch.
committed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
