On Wed, Jun 14, 2017 at 4:48 AM, Marina Polyakova <m.polyak...@postgrespro.ru> wrote: > Now in pgbench we can test only transactions with Read Committed isolation > level because client sessions are disconnected forever on serialization > failures. There were some proposals and discussions about it (see message > here [1] and thread here [2]). > > I suggest a patch where pgbench client sessions are not disconnected because > of serialization or deadlock failures and these failures are mentioned in > reports. In details: > - transaction with one of these failures continue run normally, but its > result is rolled back; > - if there were these failures during script execution this "transaction" is > marked > appropriately in logs; > - numbers of "transactions" with these failures are printed in progress, in > aggregation logs and in the end with other results (all and for each > script); > > Advanced options: > - mostly for testing built-in scripts: you can set the default transaction > isolation level by the appropriate benchmarking option (-I); > - for more detailed reports: to know per-statement serialization and > deadlock failures you can use the appropriate benchmarking option > (--report-failures). > > Also: TAP tests for new functionality and changed documentation with new > examples. > > Patches are attached. Any suggestions are welcome!
Sounds like a good idea. Please add to the next CommitFest and review somebody else's patch in exchange for having your own patch reviewed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
