Minor patch to correct erroneous warning in cvs tip, believed to be a
very minor regression.
When a shutdown was requested within CHECKPOINT_SECONDS of a checkpoint,
the shutdown code in the bgwriter (which has does checkpointing) would
issue the erroneous message:
LOG: checkpoints are occurring too frequently (%d seconds apart)
HINT: Consider increasing the configuration parameter
"checkpoint_segments".
Clearly, this should only occur when specific checkpoint requests have
been made, shutdown checkpoints should not be included in the warning.
Best regards, Simon Riggs
Index: bgwriter.c
===================================================================
RCS file: /projects/cvsroot/pgsql-server/src/backend/postmaster/bgwriter.c,v
retrieving revision 1.3
diff -c -c -r1.3 bgwriter.c
*** bgwriter.c 3 Jun 2004 02:08:03 -0000 1.3
--- bgwriter.c 11 Jun 2004 11:51:37 -0000
***************
*** 320,326 ****
*/
if (do_checkpoint)
{
! if (CheckPointWarning != 0)
{
/*
* Ideally we should only warn if this checkpoint was
--- 320,326 ----
*/
if (do_checkpoint)
{
! if (CheckPointWarning != 0 && checkpoint_requested)
{
/*
* Ideally we should only warn if this checkpoint was
---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to [EMAIL PROTECTED] so that your
message can get through to the mailing list cleanly
